It's hard to speak in generalities because the quality and condition of schools varies so much. The concept of vouchers is a good one though, it gives parents choices and refocuses the issue where it should be; educating kids.
it's a much better concept than charter schools, which essentially combines the worst of both worlds.